[BUG] Admin order create validate vat confirm box

[Swahjak]

Was broken with commit faa5f9a#diff-47459785dc7008bc9145a9609c9c7f6c and never fixed.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes [Issue] [BUG] Admin order create validate vat confirm box #29652: [BUG] Admin order create validate vat confirm box

Manual testing scenarios (*)

1. Setup a store using the magento guidelines on VAT configuration: https://docs.magento.com/user-guide/tax/vat-validation-configure.html
2. Setup store configuration that uses a origin address that's within the EU with a valid VAT ID
3. Start creating an "intra-community/union" order. Meaning; The store address must be an EU country and the order shipping address must be an EU country which is not the origin (store) country
4. Enter at least a valid e-mail address and the billing country
5. Enter a valid VAT ID for on the order
6. Click 'validate'

Expected result

6. The order creation page should show a prompt asking whether or not the customer group should be changed

Actual result

6. Nothing happens

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] [BUG] Admin order create validate vat confirm box #29652: [BUG] Admin order create validate vat confirm box

[m2-assistant]

Hi @Swahjak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[VladimirZaets]

Hi @Swahjak, thank for collaboration. Please, sign CLA, otherwise, we can't process your pull request and please take a look to my review comment

[Swahjak]

@magento run all tests

[sidolov]

@magento create issue

[gabrieldagama]

Hi @Swahjak, thanks for your pull request! It looks good! All our PR must be covered with tests, would you be able to cover this with a test? I believe MFTF tests would be enough to make sure the functionality works.

Let me know if you are available for it. Thanks.

[gabrieldagama]

The risk was set tolow due to: the suggested changes shouldn't impact other areas.

[engcom-Hotel]

Hello @Swahjak, I can help with MFTF. Could you please provide steps for reproducing.

[Swahjak]

@engcom-Hotel sorry for my absence, been busy. I have never worked with MFTF and to be honest I'm currently not in a position to get started on it, so thank you for your help. I have updated the pull requests description to better reflect the steps to reproduce this issue.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento Functional Tests B2B, Functional Tests CE

[magento-engcom-team]

Hi @gabrieldagama, thank you for the review.
ENGCOM-8287 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

@Swahjak thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Bravo]

✔️ QA Passed

1. Go to Stores - Configuration - General - General - Country Options. Set Default Country - Germany
2. Expand Store Information, select Country - Germany. Select any Region/State
3. Enter a valid German VAT Number. Validate VAT Number
4. Save Config
5. Go to Stores - Tax Rules click Add New Tax Rule
6. Click Add New Tax Rate. Set the following values:

• Country - United Kingdom
• Zip/Post is Range - checkbox Checked
• Range From - 1
• Range To - 99999999
• Rate Percent - 10
  Click Save

7. Specify Name "tax rule", for example. Assert that Rate1 and previously created rate are marked. Save Rule
8. Go to Customer - Customer Groups and create a Customer Group, with Name "newgroup" for example
9. Go to _Stores - Configuration - Customers - Customer Configuration - Create New Account Options
10. Set the following values:

• Enable Automatic Assignment to Customer Group - Yes
• Default Group - Newgroup
• Group for Valid VAT ID - Intra-Union - Retailer
• Validation Error Group - General
• Validate on Each Transaction - Yes
  Default Value for Disable Automatic Group Changes Based on VAT ID - Yes
  Save Config clear Magento Cache

11. Go to Sales - Orders, click Create New Order
12. Click Create New Customer
    (Create New Order window appears and selected group is the previously created "newgroup")
13. Change the Country to United Kingdom
14. Enter a valid United Kingdom VAT Number and click Validate VAT Number

BEFORE applying the changes provided in this PR, nothing happened after clicking Validate VAT Number

AFTER switching to this PR, a message appears ... Would you like to change the Customer Group for this order?

And after clicking OK the group is changed

[m2-assistant]

Hi @Swahjak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.