Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #292 #299

Closed
wants to merge 2 commits into from
Closed

Fix for issue #292 #299

wants to merge 2 commits into from

Conversation

ihor-sviziev
Copy link
Contributor

Fix for issue #292

@verklov
Copy link
Contributor

verklov commented Nov 7, 2013

Hello igor-svizev,
Sorry for the delay with the response.
Thank you for your contribution! Could you please provide more information related to what was the reason for the refactoring that you offer and which issues you tried to solve with it?

@ihor-sviziev
Copy link
Contributor Author

Hi verklov,
For before refactoring we haven't ability to add store information to rating collection if it was loaded before.
Also after refactoring we have same interface for adding store information for rating and reviews.

magento-team added a commit that referenced this pull request Dec 14, 2013
@magento-team
2.0.0.0-dev56
86db2ed 
* Fixed bugs:
  * Fixed placing order with PayPal Payments Advanced and Payflow Link
  * Fixed losing previously assigned categories after saving the product with changed category selector field
  * Fixed losing of a newly created category assignment after variations generation during Configurable product or Gift Card creation
  * Fixed the error in order placement with Recurring profile payment
* GitHub requests:
  * [#299](#299) -- Fix for issue Refactor Mage_Rating_Model_Resource_Rating_Collection
  * [#341](#341) -- Replacing simple preg calls with less expensive alternates
* Modularity improvements:
  * Layout page type config moved to library
  * Design loader moved to library
  * Theme label moved to library
* Themes update:
  * Reduced amount of templates and layouts in magento_plushe theme
  * Responsive design improvements
* Integrity improvements:
  * Covered all Magento classes with argument sequence validator
  * Added arguments type duplication validator
* Implemented API Integration UX flows:
  * Ability to create and edit API Integrations
  * Ability to delete API integrations that were not created using configuration files
* Removed System REST menu item and all associated UX flows:
  * Users, Roles, and Webhook Subscriptions sub-menu items were removed
* Removed the Webhook module
@verklov
Copy link
Contributor

verklov commented Dec 14, 2013

igor-svizev,
Our team has processed your pull request. The code is available in the version dev56 recently released.

Thank you for your contribution! Looking forward for your new contributions.

@verklov verklov closed this Dec 14, 2013
@ihor-sviziev
Copy link
Contributor Author

Thanks!

@ihor-sviziev ihor-sviziev deleted the refactor_rating_collection branch December 14, 2013 08:31
magento-team pushed a commit that referenced this pull request May 22, 2015
Merge pull request #299 from magento-folks/checkout
7689e4d 
[Folks+South+Troll]Checkou UI rendering
magento-team pushed a commit that referenced this pull request Jan 18, 2016
@slavvka
Merge pull request #299 from magento-south/BUGS
e02c113 
[SOUTH] Bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihor-sviziev @verklov