Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing save operation for bulk #31214

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

ityetti
Copy link

@ityetti ityetti commented Dec 8, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes New bulk schedule doesn't create operations automatically #23958
  2. Fixes Added missing save operation for bulk #31213

Manual testing scenarios (*)

  1. Create own bulk via - $this->bulkManagement->scheduleBulk($bulkUuid, $operations, $bulkDescription, $userId);
  2. Check response via PostMan when consumer will do the job

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 8, 2020

Hi @ityetti. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ityetti
Copy link
Author

ityetti commented Dec 10, 2020

@magento run all tests

Copy link
Contributor

@nuzil nuzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ityetti
Thanks for your effort,
unfortunately this solution will cause another issue, have a look here:
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/AsynchronousOperations/Model/MassSchedule.php#L169

MassSchedule will call
$this->saveMultipleOperations->execute($operations); that will save operations, and if we will merge your change, then save operation will be executed twice

@gabrieldagama gabrieldagama added the Priority: P3 May be fixed according to the position in the backlog. label May 6, 2021
@nuzil
Copy link
Contributor

nuzil commented May 19, 2021

Hey @ityetti
do you want to proceed on this one?

@ityetti
Copy link
Author

ityetti commented May 19, 2021

@nuzil Hello. I worked on this some time ago and my edits shouldn't affect on https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/AsynchronousOperations/Model/MassSchedule.php#L169
But I'll to recheck my fixes and how it will affect to the logic of class MassShedule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

Added missing save operation for bulk New bulk schedule doesn't create operations automatically
4 participants