Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not stale "Progress: ready for dev" issues #31223

Closed
wants to merge 1 commit into from

Conversation

kassner
Copy link
Contributor

@kassner kassner commented Dec 9, 2020

Description

Progress: ready for dev issues were already confirmed, so we're not waiting for additional input from anyone, but rather from development capacity. Closing a confirmed issue should only happen if 1) it's not reproducible anymore (wontfix) or 2) by a decision of product management. Time alone isn't an indication of neither of those scenarios.

Manual testing scenarios

  1. Create a bug report;
  2. Magento team confirms it by assigning the Progress: ready for dev label;
  3. The issue won't be closed by the stale bot.

@m2-assistant
Copy link

m2-assistant bot commented Dec 9, 2020

Hi @kassner. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@kassner
Copy link
Contributor Author

kassner commented Dec 9, 2020

@gabrieldagama @okorshenko this is related to #30095

@sdzhepa
Copy link
Contributor

sdzhepa commented Dec 9, 2020

Hello @kassner

Thank you for your feedback and contribution!

Stale issue bot will NOT close the critical issue with priority P0, P1, P2 or if PR is created.
It's processing only low priority issue P3, P4 and only if no any activities for 3 months (comments, labeling, assignment etc)
It was done intentionally to have a healthy and up-to-date backlog with problems that must be addressed and delivered.
And archive minor and trivial reports that do not have any attention from the community and internal teams for a long period of time.
This is an approach to manage the huge backlog and avoid situations with a lot of outdated low priority issues in the backlog.
That seems will never be fixed or were already fixed in the scope of other tasks or just become outdated after a new release.

We think it's a quite honest and transparent approach.

Anyway, each GitHub user can comment on an issue and reset closing it for 3 months again.
Can reopen or participate in regular public triage meetings to provide argumentation and rise priority to P2 P1 P0.

Considering all mentioned above, we cannot accept this PR.

@sdzhepa sdzhepa closed this Dec 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 9, 2020

Hi @kassner, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants