-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variable font size for input display on iOS #32253
Add variable font size for input display on iOS #32253
Conversation
Hi @mrtuvn. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
3a07a28
to
ad4821c
Compare
@magento run all tests |
@magento run Static Tests, Integration Tests, Functional Tests EE |
@magento create issue |
@magento run Static Tests, Functional Tests EE |
Hi @ihor-sviziev, thank you for the review. |
@magento run Static Tests, Functional Tests EE |
Hi @mrtuvn, We are closing this PR.The PR is in Draft since longtime. Once you are ready Please feel free to reopen it to process the PR further. Thanks |
Description (*)
This PR just improvement add variable default for input allow reuse in frontend
Before if we set font size below 16px when focus input display on iOS devices will zoom screen
With this variable FE devs can reuse or re-define they own value
https://stackoverflow.com/questions/2989263/disable-auto-zoom-in-input-text-tag-safari-on-iphone
https://www.warrenchandler.com/2019/04/02/stop-iphones-from-zooming-in-on-form-fields/
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: