Move assign category ids to beforeToHtml instead inside load collection

[mrtuvn]

Description (*)

The main purpose move assign category ids operation to _beforeToHtml. Clean up getLoadedProductCollection like before version 2.3. Make sure we get predictable raw data collection product (any plugin from core or 3rd-party supplier can use this entry point for get product collection data from block list). Then before render data html to browser we set data category_id to product if data available

Here is commit previous change
03a6f4d
baebe46

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Breaking BC changes in the product list block #32268

Manual testing scenarios (*)

1. Visit any category page have product lists
2. Go to details view one specific product (Should work without any problem)

Questions or comments

CC: @tzyganu

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[mrtuvn]

@magento run all tests

[mrtuvn]

@magento run all tests

[ihor-sviziev]

Hi @vzabaznov @mslabko @sidolov @sivaschenko,
Could you provide some info on why the setting category_id was added in baebe46? Can it be moved to beforeToHtml as suggested in this PR?
Unfortunately, there no clear description and test coverage for these changes.

[sivaschenko]

@ihor-sviziev category_id setting was added as part of performance improvement

[ihor-sviziev]

From @sivaschenko in slack:

This was a perfomance improvement for EE edition
I don’t think the change will break anything, but I will check with the author of the fix to make sure
The idea was to avoid calls to resource consuming $this->getCategoryIds() on each product

[ihor-sviziev]

✔ Approved

Note for QA: Please make sure this PR isn't introducing regression for performance improvement for the EE edition that was done in the scope of MC-33086.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8913 has been created to process this Pull Request

[dmitriyprime]

✔️ QA passed

[ihor-sviziev]

Moving back to "accept" status. It looks like it was moved by some mistake.

[m2-assistant]

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.