Allow deleting an encrypted backend setting #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fooman, thank you! |
|
@fooman your pull request has been merged. Thank you! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 15, 2018
MAGETWO-64282 Out of stock associated products to configurable are not full page cache cleaned #8009 MAGETWO-91532 Schedule update removes tier price MAGETWO-91547 Unable to create Credit memo for order with no payment required MAGETWO-91753 Results of filters with color and other filters are not showing product results MAGETWO-67779 Datetime attribute break fulltextsearch in case of Elasticseach MAGETWO-91495 'Invalid data provided for linked products' error on 'Save & Duplicate' product action MAGETWO-91723 Text Attribute doesn't display all character on product page MAGETWO-91553 Admin user with role scope set to custom is unable to view abandoned carts report MAGETWO-91614 [B2B] Cannot filter customers by status MAGETWO-69021 salesOrderRepositoryV1 API Missing Extension Attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you set a setting in the admin that uses
Magento\Config\Model\Config\Backend\Encryptedand save the configuration it is not possible to delete this value in the future (only replace).I have also removed some unused code in the same unit test.