Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.3.7 release - https://github.com/magento/magento2/pull/34514 #34606

Closed
wants to merge 8 commits into from
Closed

2.3.7 release - https://github.com/magento/magento2/pull/34514 #34606

wants to merge 8 commits into from

Commits on Nov 11, 2021

  1. Update AdminSessionInfo.php

    @kanhaiya5590
    kanhaiya5590 authored Nov 11, 2021
    Configuration menu
    Copy the full SHA
    6298788 View commit details
    Browse the repository at this point in the history

  2. Update AdminSessionsManager.php

    @kanhaiya5590
    kanhaiya5590 authored Nov 11, 2021
    Configuration menu
    Copy the full SHA
    5bb7188 View commit details
    Browse the repository at this point in the history

  3. Update AdminSessionInfoTest.php

    @kanhaiya5590
    kanhaiya5590 authored Nov 11, 2021
    Configuration menu
    Copy the full SHA
    12b70c9 View commit details
    Browse the repository at this point in the history

  4. Update AdminSessionsManagerTest.php

    @kanhaiya5590
    kanhaiya5590 authored Nov 11, 2021
    Configuration menu
    Copy the full SHA
    1c2d773 View commit details
    Browse the repository at this point in the history

  5. Update AdminSessionsManagerTest.php

    @kanhaiya5590
    kanhaiya5590 authored Nov 11, 2021
    Configuration menu
    Copy the full SHA
    106a6dd View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. Update AdminSessionsManager.php 

    307 | ERROR | [x] Missing short description
 308 | ERROR | [x] There must be exactly one blank line before tags
 318 | ERROR | [x] Short description should not be in multi lines
    @kanhaiya5590
    kanhaiya5590 authored Nov 12, 2021
    Configuration menu
    Copy the full SHA
    be265ff View commit details
    Browse the repository at this point in the history

  2. Update AdminSessionsManager.php 

    PHP Code Mess has found error(s):
/var/www/html/app/code/Magento/Security/Model/AdminSessionsManager.php:18	The class Magento\Security\Model\AdminSessionsManager uses sessions or cookies while not being a part of HTML Presentation layer

Failed asserting that 2 matches expected 0.
    @kanhaiya5590
    kanhaiya5590 authored Nov 12, 2021
    Configuration menu
    Copy the full SHA
    92f879d View commit details
    Browse the repository at this point in the history

  3. Update AdminSessionsManager.php

    @kanhaiya5590
    kanhaiya5590 authored Nov 12, 2021
    Configuration menu
    Copy the full SHA
    af53027 View commit details
    Browse the repository at this point in the history