-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default PHP_CodeSniffer configuration #38115
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @fredden. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@magento create issue |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
Hello @fredden, Thanks for the collaboration & contribution! ✔️ QA PassedSteps to reproduce:
Before: ✖️Both commends gave different outputs. After: ✔️Both commends gave same outputs. Thank you. |
@magento run all tests |
Since builds are failed moving this to Extended testing. |
@magento run Functional Tests B2B, Functional Tests EE |
Description
When running
vendor/bin/phpcs
(orvendor/bin/phpcbf
) without any arguments, and error is shown. When runningvendor/bin/phpcs
on a specific file, the "wrong" standard is applied. This pull request sets the "correct" defaults for PHP_CodeSniffer so that both of these scenarios work as expected - ie, that they scan the expected files with theMagento2Framework
standard.See https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#using-a-default-configuration-file
Manual testing scenarios
vendor/bin/phpcs
without any arguments.vendor/bin/phpcs app/bootstrap.php
vendor/bin/phpcs --standard=Magento2Framework app/bootstrap.php
Contribution checklist
Resolved issues: