Remove cast to (int) for the varch increment_id - see #390 #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello philwinkle, |
magento-team
added a commit
that referenced
this pull request
Dec 19, 2013
* Fixed bugs: * Fixed [MAP]: "Click for price" link is broken on the category page * Fixed tax rule search on the grid * Fixed redirect on dashboard if "Search", "Reset", "Export" buttons are clicked on several pages * Fixed switching user to alternate store-view when clicking on the Category (with Add Store Code to Urls="Yes" in the config) * Fixed printing Order/Shipping/Credit Memo from backend * Fixed 404 Error on attempt to print Shipping Label * Fixed duplication of JavaScript Resources in head on frontend * Fixed inconsistency with disabled states on Configurable product page in the Plushe theme * Fixed 3D Secure Information absence on Admin Order Info page * Fixed possibility to download or revert Backup * Fixed session fixation in user registration during checkout * Fixed fatal error during login to backend * Fixed inline translations in the Adminhtml area * Fixed partial refunds/invoices in Payflow Pro * Fixed the issue with ignoring area in design emulation * Fixed order placing with virtual product using Express Checkout * Fixed the error during order placement with Recurring profile payment * Fixed wrong redirect after customer registration during multishipping checkout * Fixed inability to crate shipping labels * Fixed inability to switch language, if the default language is English * Fixed an issue with incorrect XML appearing in cache after some actions on the frontend * Fixed product export * Fixed inability to configure memcache as session save handler * GitHub requests: * [#406](#406) -- Remove cast to (int) for the varch increment_id * [#425](#425) -- Installation of dev53 fails * [#324](#324) -- ImportExport: Easier debugging * Modularity improvements: * Removed \Magento\App\Helper\HelperFactory * Removed the "helper" method from the abstract block interface * Layout page type config moved to library * Design loader moved to library * Theme label moved to library * Remaining part from Adminhtml moved to the appropriate modules. Adminhtml module has been eliminated * Core Session and Cookie models decomposed and moved to library * \Magento\Stdlib\Cookie library created * Session Manager and Session Config interfaces provided * Session save handler interface created * Session storage interface created, session does not extend \Magento\Object anymore * Session validator interface created * Session generic wrapper moved to library * Messages functionality moved from the Session model as separate component, message manager interface created * Sid resolver interface created to handle session sid from request
|
philwinkle, |
This was referenced Dec 23, 2013
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
May 24, 2022
…hanges CABPI-227: Admin UI changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem is documented in issue #390 - this cast will force all alphanumeric increments to return a bool false or int 0 - poses a potential for collision in increment ids.