Database port missing in Magento\TestFramework\Db\Mysql #3529 #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add port number parsing to connection parameters
|
Thanks for providing a PR. /Edit: I used this patch as base against 2.0.5 to run integration tests and albeit it looks good on it's own, it also looks incomplete as tests are missing. I'll update according to my progress. /Edit2: Looks good so far. |
|
Hello @gordonknoppe, this PR has been merged in the 2.1.0 Release, that's why I'm closing it. If you any questions or additional information regarding the PR feel free to reopen it or create a new one. |
|
Looks like this was not merged. |
|
@KrystynaKabannyk: Can you share the references in the repository regarding this fix changes? |
magento-engcom-team
pushed a commit
to okorshenko/magento2
that referenced
this pull request
May 30, 2019
…aypal-express [honey] MC-15967: Paypal Express Checkout Support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3529
It is possible to configure Magento to connect a MySQL database using any port number. It is also possible to configure Magento to use any port number for connecting to a MySQL database for running integration tests. When using a port other than 3306 for integration tests PHPUnit will throw an error and not complete successfully.
Steps to reproduce:
Expected result:
Actual result (before this fix):