Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for code that is not following best practices in Magento development #48

Closed
wants to merge 2 commits into from
Closed

Patch for code that is not following best practices in Magento development #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b80a751
Fixed non reasonable usage of memory for collection, where possible t…
IvanChepurnyi Jul 19, 2012
cd665b1
Added fix for loaded object check, to prevent viewing form if address…
IvanChepurnyi Jul 19, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,11 +721,8 @@ public function transactionsAction()
public function addressAction()
{
$addressId = $this->getRequest()->getParam('address_id');
$address = Mage::getModel('Mage_Sales_Model_Order_Address')
->getCollection()
->addFilter('entity_id', $addressId)
->getItemById($addressId);
if ($address) {
$address = Mage::getModel('Mage_Sales_Model_Order_Address')->load($addressId);
if ($address->getId()) {
Mage::register('order_address', $address);
$this->loadLayout();
// Do not display VAT validation button on edit order address form
Expand Down