Fix minicart not cleared after order completion

[AntonEvers]

Fixes #4460 Fixes #4416 Fixes #1461 Fixes #4969 Fixes MAGETWO-52593

[Ctucker9233]

when is this going to be merged?

[LucScu]

great, it works

[SerhiyShkolyarenko]

@ajpevers thank you for taking part in development. All the issues you mentioned seem to be fixed by internal changes, aren't they? Is any of them still reproducible for you on develop branch or 2.0.9 release?

[PieterCappelle]

@SerhiyShkolyarenko Are you sure? I don't think so. If you compare https://github.com/magento/magento2/blob/develop/app/code/Magento/Checkout/view/frontend/templates/success.phtml (develop branch) with this PR (https://github.com/ajpevers/magento2/blob/9093ce9c2f5a4ba8c60ef0dd0769e620b4ce6f18/app/code/Magento/Checkout/view/frontend/templates/success.phtml).

The problem still exists in 2.1.2.

[Ctucker9233]

@PieterCappelle is correct. These changes do not appear in 2.1.2.

[AntonEvers]

There might be another solution to this problem, so I think only a functional test can tell. I haven't had the time yet to do this.

[Silarn]

Running 2.1.2, the minicart does not clear on order place. Testing this fix.

[chinthu]

Running 2.1.2, the minicart issue is still there and its not clearing after success checkout

[mamsincl]

Nobody mentioned before, but looks like the issue happens with guest checkout only (v2.1.2)

[sumanta-cn]

@mamsincl No, the issue is also occurring for registered customers. I got it at magento version 2.1.2

[kanduvisla]

This bug still occurs in M2.1.3. Can anyone confirm that this patch also solves this issue there?

[Ctucker9233]

@SerhiyShkolyarenko Any plans to still merge this pull request? Any idea what release version it will be in?

[redelschaap]

@SerhiyShkolyarenko Any update on this? Issue still exists in 2.1.5.

[jwittorf]

Still having the issue in 2.1.6

[surfer190]

I can confirm that this fix works for Magento 2.1.5. I am unsure what is the hold up in merging this into the repo.
Clearly a common issue.

[nntoan]

@surfer190 This is what hold up this merging:

Uncaught TypeError: Cannot read property 'sectionLoadUrl' of undefined
    at Object.getFromServer (customer-data.js:89)
    at Object.reload (customer-data.js:306)
    at (index):525
    at Object.execCb (require.js:1650)
    at Module.check (require.js:866)
    at Module.<anonymous> (require.js:1113)
    at require.js:132
    at require.js:1156
    at each (require.js:57)
    at Module.emit (require.js:1155)

[dnadle]

That error implies that the js/customer-data constructor was called with null settings. Some kind of requirejs or config failure?

I have tried to work around this cart problem by overriding Magento_Checkout/view/frontend/web/js/view/payment/default.js, adding Magento_Customer/js/customer-data to the requirements, and adding the invalidate and reload lines to the afterPlaceOrder function. I don't appear to be getting any Javascript errors after checkout. (I also don't know if it's doing anything because I've never personally been able to reproduce the bug. We've had beta testers report it only once.)

[nntoan]

@dnadle That is what exactly I'm doing for my own troubles. Instead of insert new inline javascript to success.phtml or noItems.phtml, we need to add Magento_Customer/js/customer-data into the payment method renderer and inside .done() or .always(), we use this:

customerData.invalidate(['cart']);

Reload section may leads to some potential issue with cache (!)

[AntonEvers]

I think a more elegant solution is to invalidate sections the same way as in https://github.com/magento/magento2/blob/develop/app/code/Magento/Customer/view/frontend/web/js/customer-data.js#L346 and https://github.com/magento/magento2/blob/develop/app/code/Magento/Customer/view/frontend/web/js/customer-data.js#L368.

These invalidations work based on the sections.xml files in modules but they only apply to form submits and post|put|delete calls.
If we can add the visiting of the success page to that list it would be more in line with the current approach.

[erikhansen]

UPDATE 10/11/2017 - It appears that this fix actually did fix the issue. Disregard comment below.

I applied the contents of this patch to a Magento EE 2.1.5 site and pushed it to a server running in production mode. The fix only works intermittently, but for the majority of checkouts, the minicart still shows items on the checkout confirmation page. So I would say that this PR does NOT work and an alternative solution should be used, such as the one that @ajpevers just suggested.

[dnadle]

The actual placement of the order and redirect after success happens in payment/default.js, and there is an afterPlaceOrder callback method defined. I don't understand the resistance to putting the cache invalidation there rather than listening for a get on the success page.

[ishakhsuvarov]

@ajpevers Is this PR still valid? Internal tickets show it as fixed in the develop branch.

[AntonEvers]

@ishakhsuvarov close this PR please. I cannot reproduce this issue in the develop branch. You are right.

[diazwatson]

Anybody advise the status of this issue MAGETWO-52593?

[george-vlahakis]

I am also getting it on 2.1.7 CE

[julioxx22]

It's not working on 2.1.7 EE

[GuidoHub]

Still not works on 2.1.8

[twistedatrocity]

These changes are not in 2.1.9 either.

[winterk80]

Changes are not in 2.1.8 EE, bug still exists