Add forgotten return statement #585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EliasZ, thank you for your contribution! We created the ticket and will have the team look at it. We will let you know when we have the issue resolved. |
magento-team
added a commit
that referenced
this pull request
Jul 18, 2014
* Service layer updates: * Created Tax Calculation service * Implemented search Tax Rates(search criteria) in TaxRate service * Refactored Tax Helper to use Tax Service * Validated and ensured that after helper fix, all modules with cross-dependencies use Tax Services * Refactored Bundle, Catalog, Checkout, Customer, Downloadable, Review, Logging Modules to use Tax Services * Refactored Internal Tax Module Blocks/Templates to use Tax Services * GitHub requests: * [#579] (#579) -- update GA code from ga.js to analytics.js * [#584] (#584) -- Merge and minify js - Exception * [#585] (#585) -- Add forgotten return statement * [#592] (#592) -- Module name pattern * Tax calculation updates: * Separate and display Weee line item totals from Tax * Fixed bugs: * Fixed an issue when Custom attribute template was not applied to a product during product creation * Fixed an issue when report grid with no results contained unnecessary empty "total" section * Fixed an issue where MCRYPT_RIJNDAEL_128 Cipher was set instead of 256 version * Fixed an issue when inline translate script was always included in the page even if it was not used * Fixed an issue where URL Generation was affected by previously processed URLs * Fixed an issue with cross-site scripting vulnerability via cookie exploitation * Fixed an issue with incorrect success message after system variable was deleted * Fixed an issue with category page not opening if it had bundle product with fixed price assigned to it * Fixed an issue when subtotal price in a shopping cart was not updated if the product qty is changed * Fixed an issue when syntax error appeared while creating new Google Content attribute mapping * Fixed an issue with JS error when adding associated simple product to the grouped one * Fixed an issue with incorrect items label for the cases when there are more than one item in the category * Fixed an issue when configurable product was out of stock in Google Shopping while being in stock in the Magento backend * Fixed an issue when swipe gesture in menu widget was not supported on mobile * Fixed an issue when it was impossible to enter alpha-numeric zip code on the stage of estimating shipping and tax rates * Fixed an issue when it was impossible to edit gift card account * Fixed an issue when custom price was not applied when editing an order * Fixed an issue when items were not returned to stock after unsuccessful order was placed * Fixed an issue when error message appeared "Cannot save the credit memo while creating credit memo * Fixed an issue when Catalog price rule was not shown for the product if price was less than a discount * Indexer implementation: * Implemented a new Stock indexer * Implemented a new EAV indexer * Fixed failed L1 plan on phpunit 4.1.0 * Minor updates for integration test framework * Split action controllers classes into action classes * Added public MTF repository to the packagist.org * Added the following functional tests: * Create Admin User * Create Category * Create Custom Url Rewrite * Create Frontend Product Review * Delete CMS Page * Delete Product * Delete System Variable * Update Admin User Role * Update Product Review * Indexer-less implementation of URL Rewrites functionality in new UrlRedirect module: * Ported Admin UI from old UrlRewrite module * Implemented URL Rewrites unified storage * Covered the following Magento application components with unit tests: * `Magento/Bundle/Block/Sales/Order/Items/Renderer.php` * `Magento/Bundle/Helper/Catalog/Product/Configuration.php` * `Magento/Bundle/Helper/Data.php` * `Magento/Bundle/Model/Option.php` * `Magento/Bundle/Model/Plugin/PriceBackend.php` * `Magento/Bundle/Model/Product/Attribute/Source/Price/View.php` * `Magento/Bundle/Model/Sales/Order/Pdf/Items/AbstractItems.php` * `Magento/Catalog/Model/Product/Attribute/Source/Msrp/Type/Enabled.php` * `Magento/Catalog/Model/Product/Attribute/Source/Msrp/Type/Price.php` * `Magento/Catalog/Model/Product/Visibility.php` * `Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php` * `Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php` * `Magento/Eav/Model/Entity/Attribute/Source/Boolean.php` * `Magento/Eav/Model/Entity/Attribute/Source/Table.php` * `Magento/Tax/Model/TaxClass/Source/Product.php` * Covered Magento library with unit tests : * `lib/internal/Magento/Framework/Simplexml/Config/Cache/AbstractCache.php` * `lib/internal/Magento/Framework/Simplexml/Config.php` * `lib/internal/Magento/Framework/Stdlib/DateTime/DateTime.php` * `lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php` * `lib/internal/Magento/Framework/Stdlib/String.php`
|
@EliasZ, the team processed your contribution and deployed the code in dev87. We are closing this issue. |
magento-team
pushed a commit
that referenced
this pull request
Sep 10, 2015
[EPAM] Import/Export Phase #2 Sprint 1-2
magento-engcom-team
added a commit
to okorshenko/magento2
that referenced
this pull request
May 10, 2019
…raphQL API magento#585 - Merge Pull Request magento/graphql-ce#585 from magento/graphql-ce:387-test-coverage-cms-page - Merged commits: 1. 7a90599 2. 8a5b3b7 3. b8d93d8 4. 263588a 5. 81984dc 6. f4a4a34 7. aae7428 8. cf119be 9. ff658b5 10. fed22e0 11. b4ea6b9 12. 4ee64a5 13. d7b7a2e 14. 478f438 15. 787d31b
magento-engcom-team
pushed a commit
to okorshenko/magento2
that referenced
this pull request
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came by this "issue" by accident. Hope it helps.