Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent dashboard from generating a bunch of reports when Google Charts API is unavailable #59

Closed
wants to merge 2 commits into from

Conversation

Zifius
Copy link
Member

@Zifius Zifius commented Aug 3, 2012

Log as an exception instead

@kirmorozov
Copy link
Member

Important: The Image Charts portion of Google Chart Tools has been officially deprecated as of April 20, 2012. It will continue to work as per our deprecation policy.
It's better to switch to new API.

@magento-team
Copy link
Contributor

@kirmorozov where did you find the information about deprecated API?

@kirmorozov
Copy link
Member

https://developers.google.com/chart/image/
Check out the only one message with red background.
Title also says: Image Charts (Deprecated)

P.S. Don't hide errors. fix them

@magento-team
Copy link
Contributor

@Zifius
Thank you for contribution. We have accepted it. But in order to make @kirmorozov happy as well, implementation has been improved:

  • The controller action will either return a valid image with HTTP-code 200 or a plaint text with an error message and code 503
  • The real error message is logged as exception. A message-stub is displayed to the client instead.

We chose not to bother implementing a "stub" image for now...

@Zifius
Copy link
Member Author

Zifius commented Oct 18, 2012

Thank you for accepting my contribution! Any chance to cherry-pick it to Magento 1.x?

@magento-team
Copy link
Contributor

We have no plans for porting it to Magento 1.x, sorry. You can apply it to your copy of Magento 1.x in a form of local class override.

@Zifius
Copy link
Member Author

Zifius commented Oct 18, 2012

That's fine, this is what I already did (sort of). Thanks again for accepting it!

magento-team added a commit that referenced this pull request Nov 12, 2012
* Framework changes
  * Added dependency injection of framework capability
    * Adopted Zend\Di component of Zend Framework 2 library
    * Implemented object manager in Magento application
    * Refactored multiple base classes to dependency injection principle (dependencies are declared in constructor)
  * Themes/View
    * Implemented storing themes registry in database, basic CRUD of themes, automatic registration of themes in database from file system out of the box
    * Renamed `Mage_Core_Model_Layout_Update` into `Mage_Core_Model_Layout_Merge`, the former becomes an entity domain model. Similar changes with `Mage_Core_Model_Resource_Layout` -> `Mage_Core_Model_Resource_Layout_Update`, `Mage_Core_Model_Layout_Data` -> `Mage_Core_Model_Layout_Update`
* Performance tests
  * Improved indexers running script `dev/shell/indexer.php` to return appropriate exit code upon success/failure
  * Implemented running the same performance scenario file with different parameters
  * Slightly refactored framework class `Magento_Performance_Testsuite_Optimizer` for better visibility of algorithm
* Visual design editor
  * Added ability to remove elements in editor UI
  * Revised history of changes VDE toolbar and algorithm of "compacting" operations (moving, removing elements) as a layout update XML
  * Added selection of themes to VDE launcher page
* Refactored JavaScript of some UI elements to jQuery:
  * "Simple" and "configurable" product view pages
  * "Create Account" page
  * "Shopping Cart" page
  * CAPTCHA
  * Newsletter subscription
* Tax management UX improvements
  * Split Basic and Advanced Settings for Tax Rule Management UI
  * Moved the Import/Export functionality to Tax Rate page
  * Moved Tax menu to System from Sales
* Implemented the editable multiselect JavaScript component
* Added mentioning sitemap in `robots.txt` after generation
* Removed creation of DB backup in integration testing framework
* Fixed logic of order of loading ACL resources in backend
* Fixed JavaScript error during installation when one of files in `pub/media` is not writable
* Fixed structure of legacy test fixtures that allowed ambiguous keys in declaration
* Fixed inability to restore admin password when CAPTCHA is enabled
* Various minor UX fixes (labels, buttons, redirects, etc...)
* GitHub requests:
  * [#59](#59) -- implemented handling of unexpected situations in admin/dashboard/tunnel action
  * [#66](#66)
    * refactored ImageMagick adapter unit test to avoid system operation
    * simplified unit testing framework -- removed unused classes, simplified handling logic of directory `dev/tests/unit/tmp` and removed it from VCS
  * [#73](#73), [#74](#74) -- fixes in docblock tags
  * [#75](#75), [#96](#96) -- fixed translation module contexts in a few places
  * [#80](#80) -- fixed some runtime errors in import/export module
  * [#81](#81) -- removed usage of "remove" directive in places where it is overridden by setting root template anyway
  * [#87](#87) -- changed paths of files to include from relative into absolute in `dev/shell/indexer.php` and `log.php`
  * [#88](#88) -- provided comments for values that can be configured in `app/etc/local.xml` file
  * [#90](#90) -- slightly optimized logic of implementation of loading configurable product attributes
@Zifius Zifius deleted the fix-dashboard-reports branch April 5, 2014 12:27
vpelipenko added a commit that referenced this pull request Jan 30, 2015
MAGETWO-31078: M2 GitHub Update (version 0.42.0-beta5) & Public pull requests
vpelipenko added a commit that referenced this pull request Jan 30, 2015
MAGETWO-31078: M2 GitHub Update (version 0.42.0-beta5) & Public pull requests
@stevieyu stevieyu mentioned this pull request Apr 3, 2015
@chrom chrom mentioned this pull request Oct 7, 2015
@ghost ghost mentioned this pull request Oct 21, 2017
magento-engcom-team pushed a commit that referenced this pull request Aug 17, 2018
Merge 2.3-develop to EPAM-PR-3
@FabXav FabXav mentioned this pull request Oct 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants