Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent double shipping method selection #5928

Merged
merged 1 commit into from
Feb 9, 2017
Merged

prevent double shipping method selection #5928

merged 1 commit into from
Feb 9, 2017

Conversation

danslo
Copy link
Contributor

@danslo danslo commented Aug 2, 2016 •
edited
Loading

There already is a click handler on the <tr>, so there is no need to put
it on the radio input. This prevents selectShippingMethod from being
executed twice.

For more information, see issue #5814.

Closes #5814.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 2, 2016 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@danslo
Copy link
Contributor Author

danslo commented Aug 2, 2016

Not sure why it says I haven't signed CLA, because I have :)

@piotrekkaminski
Copy link
Contributor

@danslo seems like an error, we will debug on our side - however have you seen this "Daniel Sloof seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account."? Maybe this is the problem?

@danslo
Copy link
Contributor Author

danslo commented Aug 3, 2016

@piotrekkaminski Looks like I got it fixed. Thanks for the pointer!

@vkorotun vkorotun added bugfix and removed bug report labels Aug 5, 2016
@danslo
Copy link
Contributor Author

danslo commented Sep 27, 2016

Hey guys,

Don't want to sound impatient, but this bug has been open for over 2 months and has a one line change that fixes it.

Is there anything you need done from my side?

@viktym
Copy link
Contributor

viktym commented Sep 30, 2016

Hi @danslo
We've created MAGETWO-59184 internal ticket regarding this.
Thanks for the feedback.

@viktym viktym added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 30, 2016
@viktym viktym mentioned this pull request Sep 30, 2016
Closed
@danslo
Copy link
Contributor Author

danslo commented Nov 1, 2016

Any feedback to this PR? It's been 3 months and it's a one-line change. Thanks in advance.

prevent double shipping method selection
ddb77b2 
There already is a click handler on the <tr>, so there is no need to put
it on the radio input. This prevents selectShippingMethod from being
executed twice.

For more information, see issue #5814.

Closes #5814.
@danslo
Copy link
Contributor Author

danslo commented Jan 11, 2017

We're 5 months later. Just rebased this just to be sure.

Can I please get some clarification on this ticket? Seems a straightforward fix, I have no clue about discussion in internal ticket MAGETWO-59184. Thanks.

@SerhiyShkolyarenko
Copy link
Contributor

@danslo thanks for participating!
We do some testing for this PR, then we'll merge it to mainline.

@mmansoor-magento mmansoor-magento merged commit ddb77b2 into magento:develop Feb 9, 2017
mmansoor-magento pushed a commit that referenced this pull request Feb 9, 2017
@magicbunneh
Merge pull request #816 from magento-folks/MAGETWO-59184
2149a51 
Tasks:
* MAGETWO-59184: [GITHUB] Prevent double shipping method selection #5928
@SerhiyShkolyarenko
Copy link
Contributor

done. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alena-marchenko alena-marchenko

@viktym viktym

@SerhiyShkolyarenko SerhiyShkolyarenko

Labels
bugfix Component: Checkout Component: Shipping Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danslo @magento-cicd2 @piotrekkaminski @viktym @SerhiyShkolyarenko @mmansoor-magento @vkorotun @alena-marchenko @vzaporozhets