Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation change for Text type EAV attributes #62

Closed
wants to merge 4 commits into from
Closed

Validation change for Text type EAV attributes #62

wants to merge 4 commits into from

Commits on Aug 10, 2012

  1. Validation change for Text type attributes. 

    The call on Mage_Eav_Model_Attribute_Data_Text:67 to empty returns true of a value of "0" is entered, as specified in the PHP spec. This prevents the entry of zero on the backend admin for fields. Zero should be a valid value, as it was in our case.

No unit tests were created, as no unit tests exist currently for the Eav module.
    @tim-reynolds
    tim-reynolds committed Aug 10, 2012
    Configuration menu
    Copy the full SHA
    368e2b6 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2012

  1. Merge remote-tracking branch 'upstream/master'

    @tim-reynolds
    tim-reynolds committed Aug 12, 2012
    Configuration menu
    Copy the full SHA
    74a8a32 View commit details
    Browse the repository at this point in the history

  2. Unit test created for previous commit (368e2b6) 

    Sorry for not including this originally.
    @tim-reynolds
    tim-reynolds committed Aug 12, 2012
    Configuration menu
    Copy the full SHA
    951423a View commit details
    Browse the repository at this point in the history

  3. Removed commented out line.

    @tim-reynolds
    tim-reynolds committed Aug 12, 2012
    Configuration menu
    Copy the full SHA
    f0f7857 View commit details
    Browse the repository at this point in the history