Throw exception when attribute doesn't exitst #7758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonkril
approved these changes
Jan 10, 2017
|
@AydinHassan Thank you for your PR. I am going to have a look at this and will let you know if I need any more information. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jul 18, 2022
Arrows Team - Bugfix delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating an attribute that doesn't exist we don't get a very good error message:
For example:
Notice: Undefined index: entity_type_id inThis patch throws an exception when an attributes ID could not be found with a more informative exception.
I could not see any tests for this class so I didn't add any - could add some with some pointers.