Fix #8308: test setup/src/Magento/Setup/Test/Unit/Model/Cron/JobSetCacheTest.php crashes in debug mode #8611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obSetCacheTest.php crashes in debug mode - it was crashing when running PHPUnit with --debug flag due to object passed via data provider
orlangur
deleted the
fix-test-setup/src/Magento/Setup/Test/Unit/Model/Cron/JobSetCacheTest.php
branch
|
@orlangur thank you for your contribution. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Nov 21, 2023
Tier4 PR Delivery 10.30.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was crashing when running PHPUnit with
--debugflag due to object passed via data provider (which is never a good idea - there were serious troubles with such data providers littering Bamboo in the past; cannot be solved via implementing listener preventing such kind of data provider AFAIR).