Naming Fix: DI compiler.php rename binary to igbinary to stay consistent #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @SchumacherFM, travis build are red, please check and fix it. |
SchumacherFM
force-pushed
the
diCompilerNaming
branch
from
607afd7
to
d793849
Compare
|
Oh that is a tricky one to get rid of that additional character. I've replaced ' = ' with ': ' and hope you like it. |
|
CR - passed,Builds green Resolution: Ok to merge. Ticket: MAGETWO-32331 [GITHUB] Naming Fix: DI compiler.php rename binary to igbinary to stay consistent #880 |
maksek
pushed a commit
that referenced
this pull request
Jan 5, 2015
Naming Fix: DI compiler.php rename binary to igbinary to stay consistent (MAGETWO-32331)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with app/etc/config.php entry and naming in
https://github.com/magento/magento2/blob/develop/lib%2Finternal%2FMagento%2FFramework%2FObjectManager%2FDefinitionFactory.php#L59