Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add middle name to checkout address html templates #8878 #8879

Merged
merged 3 commits into from
Jun 13, 2017

Conversation

AntonEvers
Copy link
Contributor

@AntonEvers AntonEvers commented Mar 14, 2017

Description

Three checkout address templates were lacking the middle name. they are now added.

Fixed Issues (if relevant)

  1. magento/magetno2#8878: middle name is missing from the checkout address html templates

Manual testing scenarios

  1. Create an account with a middle name and log in
  2. Add a product to the cart and go to the checkout
  3. Visit the shipping address step
  4. You should now see the middle name appear in the address name

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Mar 14, 2017
@ishakhsuvarov ishakhsuvarov added this to the June 2017 milestone Jun 8, 2017
@vherasymenko
Copy link

@ajpevers Hi. I was checked your PR and notice next:

  1. If user register account with (firstname, middlename, lastname) without filling billing address and goes "Processed to checkout" field "MiddleName" not filled automatically.
  2. If registered user with filled (all fields in his account) on checkout page clicks "New Address" firstname and lastname fields fills but middlename is empty.

Could you please fix this issues ?? Thanks.

@AntonEvers
Copy link
Contributor Author

@k7triton working on it

@AntonEvers
Copy link
Contributor Author

Found it

break;
case 'prefix':
if ($this->getCustomer()) {
return $this->getCustomer()->getPrefix();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is on middle name, I would suggest to skip other fields for the sake of testing simplicity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a new PR for prefix and suffix and remove them from this PR.

@AntonEvers
Copy link
Contributor Author

AntonEvers commented Jun 13, 2017

fixes #8878

@AntonEvers
Copy link
Contributor Author

@ishakhsuvarov I've moved the prefix/suffix prefill to #9924

@ishakhsuvarov
Copy link
Contributor

@ajpevers Thanks. We will proceed with the review shortly.

@AntonEvers
Copy link
Contributor Author

👍

@magento-team magento-team merged commit 3c632aa into magento:develop Jun 13, 2017
magento-devops-reposync-svc pushed a commit that referenced this pull request May 8, 2024
ACPT-1840: Failures on S3 related WebAPI test with Application Server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants