Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magetno2#8676: I can not translate title attribute in xml fil… #8915

Merged
merged 1 commit into from
Mar 21, 2017
Merged

magento/magetno2#8676: I can not translate title attribute in xml fil… #8915

merged 1 commit into from
Mar 21, 2017

Conversation

DanijelPotocki
Copy link
Contributor

@DanijelPotocki DanijelPotocki commented Mar 16, 2017 •
edited by avoelkl
Loading

…es translation not working

  • add translation of resource title

Description

magento/magetno2#8676: Added translation to customer resource title

Fixed Issues (if relevant)

  1. magento/magetno2#<issue_number>: Fixed issue where resource title was not being translated

Manual testing scenarios

  1. In customer resource check if title is being translated
  2. Checked if it's working with and without new code

@DanijelPotocki
magento/magetno2#8676: I can not translate title attribute in xml fil…
daeaeb4 
…es translation not working

- add translation of resource title
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 16, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@avoelkl
Copy link
Contributor

avoelkl commented Mar 16, 2017

Solves #8676

@avoelkl avoelkl self-assigned this Mar 16, 2017
@avoelkl avoelkl added this to the March 2017 milestone Mar 16, 2017
@avoelkl
Copy link
Contributor

avoelkl commented Mar 20, 2017

Thanks for the PR @DanijelPotocki, this will be merged soon!

@magento-team magento-team merged commit daeaeb4 into magento:develop Mar 21, 2017
@vrann
Copy link
Contributor

vrann commented Mar 21, 2017

@DanijelPotocki Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@avoelkl avoelkl

Labels
improvement Progress: accept
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@DanijelPotocki @magento-cicd2 @avoelkl @vrann @magento-team