Remove superfluous character in class #9044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkn98
force-pushed
the
patch-xsd-superfluous-pattern-chars
branch
from
879eed4
to
8a78c86
Compare
The solidusbackslash character ("\") was put more than once in the same
regex character class across some XSD files. Per each character class
there is no need to specify it twice.
I ran over this while looking into an issue with class-name validation
which do not allow digits within class names.
Refs:
- https://www.w3.org/TR/xmlschema11-2/#cces
- magento#4470
- magento#5420
- magento#8307
tkn98
force-pushed
the
patch-xsd-superfluous-pattern-chars
branch
from
8a78c86
to
6ce8242
Compare
|
Is this PR relies on the #5420? As far as I see ImportExport is not fixed here. |
|
@vrann No it's not fixed here, I didn't want to hijack it and appreciate some feedback first. My idea is to collect places (removing superfluous the characters in the pattern can help with finding these) where this is in place in one issue and make the pattern the same for the different places so it is more maintainable in the future. Please let me know what you think. |
|
@tkn98 thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backslash character ("
\") was put more than once in the sameregex character class across some XSD files. Per each character class
there is no need to specify it twice.
I ran over this while looking into an issue with class-name validation
which do not allow digits within class names.
Refs:
https://www.w3.org/TR/xmlschema11-2/#cces
import.xml doesn't allow numbers in vendor name and class name #4470
Fix issue #4470: import.xsd doesn't allow numbers in vendor name and class name #5420
Allow digits in communication class type definition #8307