Change interpret() return value to conform with Layout\ReaderInterface #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The integration tests failing test is not related to this PR but to Magento\Framework\Data\Form\Element\DateTest::testGetValue (I've seen other PR's of myself and others fail because of that, too). |
|
CR: passed |
vpelipenko
added a commit
that referenced
this pull request
Jan 8, 2015
Change interpret() return value to conform with Layout\ReaderInterface (MAGETWO-32404)
magento-team
pushed a commit
that referenced
this pull request
Apr 11, 2017
[East] Stabilizing Jenkins and bugfixes for 2.1.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to the develop branch replaces #751.
In the interface Layout\ReaderInterface the return value for the interpret() method is listed as $this.
This PR changes the actual return value to conform to the interface.