Non initialized log file fix #924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 6, 2015 15:57
…ing intall.log if doesnt exist
…h PHP date and one form Magento Core. DateTest.php passed
|
This issue was fixed internally in MAGETWO-31850. |
|
It is impossible to accept this pull request due to logical conflicts: the Magento Core team had fixed it in a different way in the upstream. Closing. Thank you. |
fe-lix-
pushed a commit
to fe-lix-/magento2
that referenced
this pull request
Apr 29, 2018
MSI-885: Options on Storefront Product View Page for Configurable Product Assigned to Custom Stock are Empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition to #917 mentioned issue that prevent error with:
Warning: fopen(foo\bar\Local\Temp\install.log): failed to open stream: No such file or directory in foo\bar\Projects\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 59
Warning: fseek() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 148
Warning: fgets() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 150
Warning: fclose() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 69
Warning: fopen(foo\bar\Local\Temp\install.log): failed to open stream: No such file or directory in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 59
Warning: fseek() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 148
Warning: fgets() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 150
Warning: fclose() expects parameter 1 to be resource, boolean given in foo\bar\magento2\setup\module\Magento\Setup\src\Model\WebLogger.php on line 69
{"progress":"0","success":true,"console":[]}
To reproduce error just cause "installation not completed" error and then clear console and click "Try Again". The first action is "progress" with progress == 100 and multiple error due to not existing resource.
To prevent it I added simple is_resource check for fclose function and also on open() function to create file if doesn't exists.
I didn't have this issue during next 10 installation processes after this fix.