Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply pattern matching datasource config files #968

Merged
merged 2 commits into from
Jan 15, 2015
Merged

Apply pattern matching datasource config files #968

merged 2 commits into from
Jan 15, 2015

Commits on Jan 14, 2015

  1. Add test to uncover glob pattern not being applied

    The Magento\Ui\DataProvider\Config\FileResolver does not apply the
    filename glob pattern passed to the method while matching files.
    This test triggers the error.
    Vinai committed Jan 14, 2015
    Configuration menu
    Copy the full SHA
    fd3a80e View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2015

  1. Apply pattern matching datasource config files

    The Magento\Ui\DataProvider\Config\FileResolver class currently
    uses the hardcoded pattern '/*/*/etc/data_source/*' to search
    for data source configuration files.
    The method argument $filename, which contains the file pattern that should
    be matched, is not used.
    Due to this temorarily excludng files by renaming them
    with a different file type ending is not possible.
    For example
    
        etc/data_source/customer.xml -> etc/data_source/customer.xml.off
    
    This patch applies the specified file name pattern to the pattern.
    Vinai committed Jan 15, 2015
    Configuration menu
    Copy the full SHA
    181be0d View commit details
    Browse the repository at this point in the history