Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when getting thumbnails on order row for deleted products #4307

Open
1 of 8 tasks
vacla opened this issue Aug 2, 2024 · 5 comments · May be fixed by #4308 or #4342
Open
1 of 8 tasks

Error when getting thumbnails on order row for deleted products #4307

vacla opened this issue Aug 2, 2024 · 5 comments · May be fixed by #4308 or #4342
Assignees
Labels
bug Something isn't working Progress: PR approved

Comments

@vacla
Copy link

vacla commented Aug 2, 2024

Describe the bug

When getting orders with deleted products, it gives an error here:

query GetProductThumbnailsByURLKey($urlKeys: [String!]!) {

This is the error:

{
    "errors": [
        {
            "message": "Variable \"$urlKeys\" got invalid value [null,null]; Expected non-nullable type String! not to be null at value[0].\n\nVariable \"$urlKeys\" got invalid value [null,null]; Expected non-nullable type String! not to be null at value[1].",
            "extensions": {
                "category": "graphql"
            }
        }
    ]
}

To reproduce

Steps to reproduce the behavior:

  1. Login in account
  2. Place order with 1 product
  3. Delete this product out of magento
  4. Go to order history page
  5. See error in console

Expected behavior

No error

Possible solutions

Make this an optional string:

query GetProductThumbnailsByURLKey($urlKeys: [String!]!) {

Debug Report

ℹ Inspecting Dependencies
Found 9 https://github.com/magento dependencies in yarn.lock
@magento/pwa-buildpack @ 11.4.3
@adobe/apollo-link-mutation-queue @ 1.0.2
@magento/babel-preset-peregrine @ 1.2.3
@magento/eslint-config @ 1.5.3
@magento/pagebuilder @ 8.2.1
@magento/peregrine @ 13.2.1
@magento/pwa-theme-venia @ 1.4.0
@magento/venia-adobe-data-layer @ 1.0.0
@magento/venia-ui @ 10.3.0

ℹ Inspecting Magento Backend
Not using sample backend.
Backend is UP!

ℹ Inspecting System
OS: #39 SMP PREEMPT_DYNAMIC Fri Jul 5 21:49:14 UTC 2024
Node Version: v16.20.2
NPM Version: 8.19.4

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]: PC
  • Browser [e.g. Chrome, Safari]: Chrome
  • Browser Version [e.g. 22]: 127.0.6533.72
  • Magento Version [e.g Adobe Commerce 2.4]: commerce 2.4.5-p8

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@vacla vacla added the bug Something isn't working label Aug 2, 2024
Copy link

m2-assistant bot commented Aug 2, 2024

Hi @vacla. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

@glo82145
Copy link
Collaborator

@adobe export issue to JIRA project PWA as Bug

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3359 is successfully created for this GitHub issue.

@del15881
Copy link
Collaborator

del15881 commented Oct 7, 2024

Hi @vacla

Thank you for bringing this up!

Could you please clarify why you are deleting a product from the backend and checking the order history for deleted products ?

we are curious if this is a specific case for any of your clients or if it has caused issues in one of your projects.

Thanks.

@del15881 del15881 added Issue: Needs Update Additional information is require, waiting for response and removed Issue: Needs Update Additional information is require, waiting for response labels Oct 7, 2024
@vacla
Copy link
Author

vacla commented Oct 7, 2024

@del15881 We are removing them when they are no longer in the collection available.
Our client wants us to show the history of all previously placed orders to the customers, all info is always available in the orders table that is needed to show this.

If the product wasn't available we would want to show the placeholder image what is currently not possible due to this bug as it will error at that moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Progress: PR approved
Projects
None yet
4 participants