Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3359 : Allowing null values into the Product Thumbnail GrapQL in … #4342

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

del15881
Copy link
Collaborator

@del15881 del15881 commented Oct 9, 2024

…orderRow.pql.js and Adding Transparent Placeholder image for deleted products on order history screen in collapsedImageGallery.js file.

Description

This PR fixes the Issue seen on the PWA order history page when one or more ordered products have been deleted from
Magento database.

Related Issue

Closes #4307.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

…orderRow.pql.js and Adding Transparent Placeholder image for deleted products on order history screen in collapsedImageGallery.js file.
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 9, 2024

Fails
🚫 A version label is required. A maintainer must add one.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against ddba300

@del15881 del15881 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Oct 10, 2024
@del15881 del15881 requested a review from glo82145 October 10, 2024 07:49
@del15881 del15881 self-assigned this Oct 10, 2024
@del15881
Copy link
Collaborator Author

@adobe run pr test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: approved version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when getting thumbnails on order row for deleted products
3 participants