chore: Remove unused App component breaking test watch mode #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Jest dep to `^23.4.0`, fixing jestjs/jest#6407 which caused our `test:dev` script to appear to hang when files were modified and Jest cache was absent. The original behavior froze at this message: Determining test suites to run... The new version of Jest properly prints the error message: Determining test suites to run... Configuration error: Could not locate module src/store/reducers/navigation mapped as: /Users/jzetlen/gits/pwa/pwa-studio/packages/venia-concept/src/store/reducers/navigation. Please check your configuration for these entries: { "moduleNameMapper": { "/^src\/(.+)/": "/Users/jzetlen/gits/pwa/pwa-studio/packages/venia-concept/src/$1" }, "resolver": null } - Removed the `App` component, which is now unused due to the `MagentoResolver` calling `RootComponents` directly, and was the source of the mapping error above. Future errors of this kind will appear early and should be easier to diagnose and fix.
DrewML
approved these changes
Jul 11, 2018
jimbo
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[x] Bugfix
[ ] Test for existing code
[ ] Documentation
Summary
Updated Jest dep to
^23.4.0, fixing fix: properly reprint resolver errors in watch mode jestjs/jest#6407 which caused ourtest:devscript to appear to hang when files were modified and Jest cache was absent. The original behavior froze at this message:The new version of Jest properly prints the error message:
Removed the
Appcomponent, which is now unused due to theMagentoResolvercallingRootComponentsdirectly, and was the source of the mapping error above. Future errors of this kind will appear early and should be easier to diagnose and fix.Additional information