Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VULN-25329: Removing obsolete docs directory #4144

Closed
wants to merge 1 commit into from

Conversation

jeff-matthews
Copy link
Contributor

@jeff-matthews jeff-matthews commented Jul 17, 2023

Description

This pull request (PR) deletes the pwa-devdocs/ directory from the project.

Documentation was migrated to the https://github.com/AdobeDocs/commerce-pwa-studio repo and that's where it is actively maintained. That's also the source that we deploy to production.

Related Issue

VULN-25329

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node` failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unable to create scaffolded project.

DEBUG_PROJECT_CREATION=1 packages/create-pwa/bin/create-pwa

failed.
Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.

Messages
📖

Associated JIRA tickets: VULN-25329.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: eslintCheck


ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 4c2477b

@jeff-matthews
Copy link
Contributor Author

I'm not sure why it's showing merge conflicts. I'm also not sure how to resolve them.

@jeff-matthews
Copy link
Contributor Author

Oh, I know what happened. I used the wrong branch in my fork. I'll open a new PR.

@jeff-matthews
Copy link
Contributor Author

See #4146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants