Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Transparent Placeholder SVG with the Magento Placeholder SVG #4344

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

del15881
Copy link
Collaborator

@del15881 del15881 commented Oct 16, 2024

Description

Replacing the encoded Transparent placeholder SVG image with the Default Magento Placeholder Image. This fixes the Placeholder Issue on "Category Pages", "Product Details Page", "Cart Page","Checkout Pages" and "Order History Page".

Related Issue

Closes #PWA-3373.
https://jira.corp.adobe.com/browse/PWA-3373

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/venia-ui/lib/components/ProductImageCarousel/__tests__/carousel.spec.js
  • packages/venia-ui/lib/components/WishlistPage/__tests__/wishlistItem.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ItemsReview/__tests__/itemsReview.spec.js
  • packages/venia-ui/lib/components/MiniCart/ProductList/__tests__/item.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/EditModal/__tests__/productForm.spec.js
  • packages/venia-ui/lib/components/Gallery/__tests__/gallery.spec.js
  • packages/venia-ui/lib/components/Gallery/__tests__/item.spec.js
  • packages/venia-ui/lib/components/ProductImageCarousel/__tests__/thumbnail.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/item.spec.js
  • packages/venia-ui/lib/components/SearchBar/__tests__/suggestedProduct.spec.js
  • packages/venia-ui/lib/RootComponents/Category/__tests__/categoryContent.shimmer.spec.js
Messages
📖

Associated JIRA tickets: PWA-3373.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 7dac1c7

@del15881 del15881 added version: Minor This changeset includes functionality added in a backwards compatible manner. pkg:peregrine and removed pkg:peregrine labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine Progress: ready for review version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants