Fix incorrect field type for mp_smtp_ace_token
#418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Field
mp_smtp_ace_tokenof thequotetable currently has typesmallint, so it can't handle the generated token. It looks like when the code was switching from the setup scripts to the DB Schema approach, the field type was accidentally set incorrectly.Here we can see that the content that is put into the field should be a string:
\Mageplaza\Smtp\Observer\Quote\SetToken.This PR reverts the
mp_smtp_ace_tokenfield type back to varchar 255.Related Pull Requests
No related PR were found.
Fixed Issues (if relevant)
No open issues were found.
Manual testing scenarios
quotetablemp_smtp_ace_tokenis generated correctly for your quoteQuestions or comments
No extra questions or comments.