Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature PluginList and QueriesList #3

Closed
lewisvoncken opened this issue Feb 2, 2017 · 7 comments
Closed

Feature PluginList and QueriesList #3

lewisvoncken opened this issue Feb 2, 2017 · 7 comments

Comments

@lewisvoncken
Copy link
Contributor

Hello @phoenix128 ,

I have added two new features to the MSP DevTools module.

I will also sent you a commit for the chrome extension. Let me know if you integrate this feature.

By the way Thanks for the great module and chrome extension!

You can find my commit in the attachment:

mage2-msp-devtools-feature.txt

@slackerzz
Copy link
Member

Hi @lewisvoncken,
can you open a pull request please?
Thank you

@lewisvoncken
Copy link
Contributor Author

lewisvoncken commented Feb 2, 2017 via email

@phoenix128
Copy link
Contributor

@lewisvoncken , you do not need any permission to do this. You have to fork the project and open a pull request.

Look here: https://help.github.com/articles/creating-a-pull-request/

@lewisvoncken
Copy link
Contributor Author

lewisvoncken commented Feb 2, 2017 via email

@phoenix128
Copy link
Contributor

phoenix128 commented Feb 2, 2017

Your job seems awesome! Thank you very much for your contribution.
We will merge it ASAP.

@lewisvoncken
Copy link
Contributor Author

lewisvoncken commented Feb 2, 2017 via email

@phoenix128
Copy link
Contributor

phoenix128 commented Feb 3, 2017

Hi @lewisvoncken ,
we merged your work with few modifications and add-ons you will appreciate.

Upgrade both Magento2 module and Chrome extension (it will be available in the next few hours).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants