Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing detached db objects #4418

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fixing detached db objects #4418

merged 2 commits into from
Oct 17, 2024

Conversation

bitbyt3r
Copy link
Member

@bitbyt3r bitbyt3r commented Oct 17, 2024 •
edited
Loading

This removes the explicit call to expunge_all prior to returning the page generator. Instead we rely on the SessionManager to call session.close() during __exit__ which should also handle expunging objects.

@bitbyt3r bitbyt3r changed the title Reverting admin retrieval Fixing detached db objects Oct 17, 2024
@bitbyt3r bitbyt3r requested a review from kitsuta October 17, 2024 21:59
kitsuta
kitsuta approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@kitsuta kitsuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding what was causing this!

@kitsuta kitsuta merged commit e61ed62 into main Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsuta kitsuta kitsuta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitbyt3r @kitsuta