feat(kubernetes): validate text manifests when rollout strategies ena…

…bled
maggieneterval · Apr 19, 2019 · 0ec6a7e · 0ec6a7e
1 parent 2056b64
commit 0ec6a7e
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/...pts/modules/kubernetes/src/v2/pipelines/stages/deployManifest/deployManifest.validator.ts b/...pts/modules/kubernetes/src/v2/pipelines/stages/deployManifest/deployManifest.validator.ts
@@ -2,6 +2,10 @@ import { get, isEmpty } from 'lodash';
 
 import { IPipeline, IStage, IValidatorConfig, ICustomValidator } from '@spinnaker/core';
 
+import { strategyRedBlack } from 'kubernetes/v2/rolloutStrategy/redblack.strategy';
+
+const MAX_VERSION_HISTORY_ANNOTATION = 'strategy.spinnaker.io/max-version-history';
+
 export const deployManifestValidators = (): IValidatorConfig[] => {
   return [
     {
@@ -12,6 +16,20 @@ export const deployManifestValidators = (): IValidatorConfig[] => {
         if (enabled && isEmpty(services)) {
           return `Select at least one <strong>Service</strong> to enable Spinnaker-managed rollout strategy options.`;
         }
+        if (enabled && stage.source === 'text') {
+          const manifests = get(stage, 'manifests', []);
+          if (manifests.length !== 1 || get(manifests, [0, 'kind']) !== 'ReplicaSet') {
+            return 'Spinnaker can manage traffic for ReplicaSets only. Please enter exactly one ReplicaSet manifest or disable rollout strategies.';
+          }
+          const strategy = get(stage, 'trafficManagement.options.strategy');
+          const maxVersionHistory = parseInt(
+            get(manifests, [0, 'metadata', 'annotations', MAX_VERSION_HISTORY_ANNOTATION]),
+            10,
+          );
+          if (strategy === strategyRedBlack.key && maxVersionHistory < 2) {
+            return `The max version history specified in your manifest conflicts with the behavior of the Red/Black rollout strategy. Please update your <strong>${MAX_VERSION_HISTORY_ANNOTATION}</strong> annotation to a value greater than or equal to 2.`;
+          }
+        }
         return null;
       },
     } as ICustomValidator,