added sourceBox parameter to resizeInto in RasterYuv420Semiplanar #1852
Conversation
ghost
added
the
| resizeInto: func (target: This) { | ||
| resizeInto: func (target: This, sourceBox := IntBox2D new()) { | ||
| if (sourceBox hasZeroArea) | ||
| sourceBox = IntBox2D new(this size) |
There was a problem hiding this comment.
I suppose sourceBox := IntBox2D new(this size) does not work as a default argument?
There was a problem hiding this comment.
I think it is evaluated only once. It does not seem to be a problem now, but maybe someone would like to change the size at some point.
Should I change it anyway ?
There was a problem hiding this comment.
This is fine. I think my suggestion actually does not work.
| thisStride := srcRow * this uv stride / 2 | ||
| targetStride := row * target uv stride / 2 | ||
| for (column in 0 .. targetSizeHalf x) { | ||
| srcColumn := (thisSizeHalf x * column) / targetSizeHalf x | ||
| srcColumn := (thisSizeHalf x * column) / targetSizeHalf x + sourceBox left / 2 |
There was a problem hiding this comment.
Oh, I should ask: You are reading the sourceBox properties once per iteration, do you want to speed them up as you did with thisSize* and targetSize*?
There was a problem hiding this comment.
lines 105, 109, 120, 124
There was a problem hiding this comment.
We can do that later, I'm currently still working on this function.
There was a problem hiding this comment.
It's what they pay me for.
ghost
deleted the
This allows to crop & resize in single pass.
@marcusnaslund review