[FIX]: removing unneeded NFT module and related code #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinnout
reviewed
May 2, 2023
Comment on lines
-32
to
-57
| test('Successfully POSTs to the given endpoint and adds JSON header', async () => { | ||
| const fetchStub = jest.fn().mockImplementation(() => successRes); | ||
| (fetch as any) = fetchStub; | ||
|
|
||
| await expect( | ||
| post( | ||
| 'https://example.com/hello/world', | ||
| API_KEY, | ||
| { public_address: '0x0123' }, | ||
| { 'Content-Type': 'application/json' }, | ||
| ), | ||
| ).resolves.toBe('hello world'); | ||
|
|
||
| const fetchArguments = fetchStub.mock.calls[0]; | ||
| expect(fetchArguments).toEqual([ | ||
| 'https://example.com/hello/world', | ||
| { | ||
| method: 'POST', | ||
| headers: { | ||
| 'X-Magic-Secret-key': API_KEY, | ||
| 'Content-Type': 'application/json', | ||
| }, | ||
| body: '{"public_address":"0x0123"}', | ||
| }, | ||
| ]); | ||
| }); |
There was a problem hiding this comment.
Can we keep this? doesn't look NFT related
There was a problem hiding this comment.
I added this in a PR for minting, basically needed to add in the secret key header specifically for minting -- here's where it was added: https://github.com/magiclabs/magic-admin-js/pull/107/files#diff-1dafd08f79b2abad5cee6ab033b9a92fd6e01257c287673b6eb533a9c558335aR32
This test is for this change, which is only needed by minting: https://github.com/magiclabs/magic-admin-js/pull/108/files#diff-3ca6a15d564c2c26d46054f3bde8c43d1e5c79865143e55ad08164353ef58320L54
justinnout
approved these changes
May 3, 2023
|
🚀 PR was released in |
This was referenced Jun 9, 2024
This was referenced Jun 17, 2024
This was referenced Jun 25, 2024
This was referenced Aug 25, 2024
This was referenced Sep 2, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
For NFT Checkout, approved clients will call our REST API endpoints directly rather than using the SDK. Removing all references to NFT service from this repo.
✅ Fixed Issues
🚨 Test instructions