Adding type and abis #122
Merged
Adding type and abis #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethella
reviewed
Mar 8, 2024
| didToken: string, | ||
| contractAddress: string, | ||
| contractType: 'ERC721' | 'ERC1155', | ||
| web3: Web3, |
There was a problem hiding this comment.
Curious, why web3 needs to be a param in this case?
There was a problem hiding this comment.
Just a thought, maybe web3 can be a peer dependency, which can keep our admin sdk light-weight and thin
There was a problem hiding this comment.
I made it a param to make the mocks more straightforward in the unit tests, and also to allow the users to pass in web3 instances that may have custom options.
I'm not familiar with peer dependencies, looking into it
There was a problem hiding this comment.
moved into peer dependencies @Ethella
…pendency-versions-to-support-web-3 Pdeexp 594 update admin sdk dependency versions to support web 3
Ethella
approved these changes
Apr 3, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
✅ Fixed Issues
🚨 Test instructions