Validate client ID in DID Token. #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinnout
reviewed
Jun 29, 2023
Comment on lines
+40
to
+42
| init_requests_client = RequestsClient(retries, timeout, backoff_factor) | ||
| magic_admin.client_id = client_id or \ | ||
| init_requests_client.request('get', self.v1_client_info).data['client_id'] |
There was a problem hiding this comment.
You can use the client already set up
There was a problem hiding this comment.
It's scoped to the specific Resources :( I ran into issues trying to get it to work with the existing client so I ended up initializing my own.
|
Still need to test this thoroughly (build the library, install it, try making the calls) |
justinnout
previously approved these changes
Jun 29, 2023
magic-ravi
force-pushed
the
ravi-sc80094-ValidateAud
branch
from
7b42f99
to
b946257
Compare
magic-ravi
force-pushed
the
ravi-sc80094-ValidateAud
branch
from
d93ea40
to
61de346
Compare
justinnout
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
[Provide a general summary of the pull request here.]
Validate
audfield in DID Token by comparing it to client ID. Pull Client ID from Magic servers if not present.🗜 Versioning
(Check one!)
✅ Fixed Issues
🚨 Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Tested:
CHANGELOG.mdUpcoming Changessection ofCHANGELOG.mdwith context related to this Pull Request.