Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initiated the frontend #1

Merged
merged 4 commits into from
Jan 12, 2024
Merged

initiated the frontend #1

merged 4 commits into from
Jan 12, 2024

Conversation

magihoefkens
Copy link
Owner

No description provided.

Copy link
Contributor

@MoinMarcell MoinMarcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, but why did you installed MUI? You are not using it?

@@ -10,9 +10,13 @@
"preview": "vite preview"
},
"dependencies": {
"@emotion/react": "^11.11.3",
"@emotion/styled": "^11.11.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of late 2021, styled-components is not compatible with server-rendered Material UI projects. This is because babel-plugin-styled-components isn't able to work with the styled() utility inside @mui packages. See this GitHub issue for more details.

We strongly recommend using Emotion for SSR projects.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hallo Marcell, ich habe mir gestern Mui ansgechaut und installiert, denn ich habe mir gedacht, da ich kein css kann, das mir eine gute Vorlage liefern würde... ehrlicherweise, bin ich von deinem Beispiel inspiriert worden. Ist das keine so gute Idee? Viele Grüße, Marianna

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyho, na klar kannst du MUI nutzen, aber du hast styled components installiert, dass brauchst du nicht, da es veraltet ist und zu problemen führen kann und bisher, zumindest in diesem Pull Request nutzt du kein MUI

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verstehe, danke für den Hinweis. Wie kann ich das rückgängig machen: reicht es wenn ich Zeile 14 aus der package.json lösche?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

genau!:)

frontend/src/App.tsx Outdated Show resolved Hide resolved
magihoefkens and others added 2 commits January 12, 2024 10:57
Co-authored-by: Marcell <marcell.dechant@protonmail.com>
Copy link
Contributor

@MoinMarcell MoinMarcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!:)

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed for 'marianna-hoefkens_ski_school_planner-frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed for 'backend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@MoinMarcell MoinMarcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!:)

@magihoefkens magihoefkens merged commit 2d3c484 into main Jan 12, 2024
5 checks passed
@magihoefkens magihoefkens deleted the feature-frontend-instructor branch January 12, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants