-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initiated the frontend #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far, but why did you installed MUI? You are not using it?
frontend/package.json
Outdated
@@ -10,9 +10,13 @@ | |||
"preview": "vite preview" | |||
}, | |||
"dependencies": { | |||
"@emotion/react": "^11.11.3", | |||
"@emotion/styled": "^11.11.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of late 2021, styled-components is not compatible with server-rendered Material UI projects. This is because babel-plugin-styled-components isn't able to work with the styled() utility inside @mui packages. See this GitHub issue for more details.
We strongly recommend using Emotion for SSR projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hallo Marcell, ich habe mir gestern Mui ansgechaut und installiert, denn ich habe mir gedacht, da ich kein css kann, das mir eine gute Vorlage liefern würde... ehrlicherweise, bin ich von deinem Beispiel inspiriert worden. Ist das keine so gute Idee? Viele Grüße, Marianna
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heyho, na klar kannst du MUI nutzen, aber du hast styled components installiert, dass brauchst du nicht, da es veraltet ist und zu problemen führen kann und bisher, zumindest in diesem Pull Request nutzt du kein MUI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verstehe, danke für den Hinweis. Wie kann ich das rückgängig machen: reicht es wenn ich Zeile 14 aus der package.json lösche?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
genau!:)
Co-authored-by: Marcell <marcell.dechant@protonmail.com>
…d only @emotion/react
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!:)
Quality Gate passed for 'marianna-hoefkens_ski_school_planner-frontend'Kudos, no new issues were introduced! 0 New issues |
Quality Gate passed for 'backend'Kudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!:)
No description provided.