fixed character numbers for windows #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very funny, as #65 did the exact opposit XD. This is a generall problem with the lookuptable. the value for I fixed this and a few more windows specific things in #71, which still waits on beeing merged. |
Closed
Cube707
added a commit
that referenced
this pull request
Jul 24, 2022
the windows scancodes consist of two bytes, the first denoting a special scancode and the second being the actual key information. Previously both bytes where used to calculate the number to look up in a dictionary, but as only the second byte is actually different, this can be simplified. closes #75, closes #66, closes #9, closes #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readkey code uses getch to get the character number for the arrow keys in windows, but it uses the formula a + ( b * 256 ) to get the character numbers. a being the escape with value 224. In the xlate_dict the numbers do not include the extra 224 from a so the keys don't work.