-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce -defun #336
base: master
Are you sure you want to change the base?
Introduce -defun #336
Conversation
LGTM, maybe add some link/docs on the README on how to use? |
For every |
@basil-conto addressed comments and force-pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed comments and force-pushed.
Thanks, but some of the docs still contain mistakes; see below.
By the way, dash.el
is now included in GNU ELPA and is copyrighted by the Free Software Foundation. Do you have a copyright assignment on file?
55a2a29
to
2915dfd
Compare
Sorry about that, please check the newly force pushed version(hopefully I have fixed everything).
I don't have an assignment. |
Would you be willing to? You only need to do it once for all FSF-copyrighted Emacs packages, including Emacs core. It involves filling out one of the forms under http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright and emailing it to assign@gnu.org. They'll tell you what you need to do from there. See also |
- I used `-lambda` as a base, tried several versions with extracting the common code but neither of them made the code more readable(IMO). - Removed the restrictions against doing `(-lambda () ...)` which does not seem to needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. All that's missing is the copyright assignment.
Ping. |
any news on that @basil-conto ? |
Any news on what? I lack both the ability to check whether @yyoncho's copyright assignment is on file, and to merge this PR. |
Yeah, sorry for that :/ |
No worries. :) Perhaps if the |
FWIW I started copyright assignment but it is not a blocker for the merge either way since I have already 2 commits with more than 15(?) lines in the repo. And generally, we need it in melpa, not sure if having a newer version in elpa will be sufficient. |
There was a lot of effort put into getting
The status of |
By "we", I meant |
I don't see how that would be a problem. |
package.el will pick the melpa version and we will break if it does not have -defun. We will break even now if anyone was using the elpa version because AFAICT dash was not updated in elpa for like 5 years... |
If GNU ELPA has
Which is something that I would like to change. |
I agree with you, Basil, that we should wait for the CA to be in order, and
I’m happy that you’re putting in the effort to get us back on track.
man. 1. jun. 2020 kl. 22:18 skrev Basil L. Contovounesios <
notifications@github.com>:
… package.el will pick the melpa version and we will break if it does not
have -defun.
If GNU ELPA has -defun, then MELPA will also have it.
We will break even now if anyone was using the elpa version because AFAICT
dash was not updated in elpa for like 5 years...
Which is something that I would like to change.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#336 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACA4OIM2YTVY3ND3MJJ2ETRUQEIBANCNFSM4NELLTYA>
.
|
Since Emacs Lisp has a global namespace, you could include the function in
your own code while waiting for this to propagate to the package repos,
perhaps?
man. 1. jun. 2020 kl. 21:17 skrev Ivan Yonchovski <notifications@github.com
…:
And generally, we need it in melpa, not sure if having a newer version in
elpa will be sufficient.
The status of dash.el, as a widely used Emacs package, on GNU ELPA is far
more important than its status on MELPA.
By "we", I meant emacs-lsp team. Having it in elpa does not work for us
because the melpa version will be higher(I guess).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#336 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACA4OJN4FCDDWME3OXEXI3RUP5EHANCNFSM4NELLTYA>
.
|
I haven't tested this, but would |
Any updates on that?
It seems to - so is |
I will try to finish that these days.
I don't insist on getting this in - we already defined lsp-defun in lsp-mode. |
I used
-lambda
as a base, tried several versions with extracting the commoncode but neither of them made the code more readable(IMO).
Removed the restrictions against doing
(-lambda () ...)
which does not seemto needed.