-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced all occurrences of even?
with evenp
#342
base: master
Are you sure you want to change the base?
Conversation
Also replaced occurrences of `odd?` with `oddp`.
Only if you load the
They're defined in the file that generates the examples, That said, it's always irked me that the output of this file does not include their definitions. Instead of using deprecated |
Note also that you shouldn't modify |
How about 4) Rename to |
Is it really worth further blurring the boundaries of the Dash API for the sake of how and which examples are published? I'm obviously not going to oppose the decision, I just think there are simpler solutions. |
It wasn’t a decision. It was a suggestion. As implied by the question
marks. Go for whatever feels best.
tir. 11. aug. 2020 kl. 12:22 skrev Basil L. Contovounesios <
notifications@github.com>:
… Is it really worth further blurring the boundaries of the Dash API for the
sake of how and which examples are published?
I'm obviously not going to oppose the decision, I just think there are
simpler solutions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#342 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACA4OJIDTKMRPWTTHLDZTTSAELWTANCNFSM4P2KML4Q>
.
|
Sorry, I didn't mean to come across as accusatory. I only meant to say that I'm ultimately fine with any of the solutions, but don't think the generation of examples is worth going into too much trouble for. |
Thanks for all the feedback. I'll revert the changes to the README.md (of course) And, if you concur, I'll go with @basil-conto 's first suggestion and alter the examples to use, say |
* dev/examples.el (odd?): Remove function. (-drop-while, -partition-after-pred, -partition-before-pred) (-each-while, -each-r-while): Replace odd? with built-in functions (#342). * README.md: * dash.texi: Regenerate docs.
I've since been chipping away at the non-standard functions whenever I was changing tests for other reasons, and finally I'm not going to tackle I think such a cumulative change should be exempt from copyright paperwork, but if you'd like to continue contributing to Dash, Emacs, or other FSF-copyrighted projects, then I'd encourage you to start the copyright assignment process, if you haven't already :). If you're unfamiliar with this, see |
Also replaced occurrences of
odd?
withoddp
.Emacs Lisp provides
evenp
andoddp
and apparently the use of (not defined) functionseven?
andodd?
caused confusion for some readers. [I won't cry if you ignore this pull request.]