Fix bug with -is-suffix? #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dash.el (-is-suffix?): Don't assume that first element of suffix appears only once (PR magnars#384). This fixes a regression in v2.18.0. Copyright-paperwork-exempt: yes
* NEWS.md (2.19.1): Announce fix for -is-suffix-p regression. (2.19.0): Refill. * dev/examples.el (-is-suffix?): Test for regression.
|
Thanks for catching this, and sorry about this blunder! I'll cut 2.19.1 as a bugfix release shortly. |
basil-conto
added a commit
that referenced
this pull request
Aug 26, 2021
* dash.el: Bump to version 2.19.1. * README.md: * dash.texi: Regenerate docs. Re: #384.
Done: https://github.com/magnars/dash.el/releases/tag/2.19.1 Should be live on GNU ELPA and GNU-devel ELPA within a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
-is-suffix?tries to find the first element oflistthat matches the first element ofsuffixand then checks to see if the rest oflistmatchessuffix. However, this means that examples like(-is-suffix? '(a b) '(a c a b))evaluate to false, which should be a bug. This new implementation fixes the bug.