Create a Pcase pattern that works like -let.
#413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil-conto
added
the
enhancement
okamsn
force-pushed
the
pcase
branch
3 times, most recently
from
672d344
to
abc48e2
Compare
- Create file `dash-pcase.el`. - Copy tests of `-let` (except for parallel binding tests) to test pattern in `pcase` and `pcase-let`. - Update `README.md` and Info documentation using `make`.
|
This is now ready for review. I've copied the tests of Should the Do you want any changes in how the code works or its style? Thank you. |
- Create a substitute for `gensym` if `gensym` is not available. - Warn that `dash-pcase` not supported in Emacs versions less than 25.1. - Only run tests if `pcase-defmacro` is bound.
|
I have updated the code to use How would you like to handle Emacs versions when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the beginning of a
pcasepattern that works like-let. For me, this would resolve #376 (which I opened).Before I copy the tests for
-letand work through the edge cases of the pattern, would you be willing to merge apcasepattern that works like-let?