Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Support #367

Closed
magneticstain opened this issue Jan 15, 2024 · 3 comments · Fixed by #368 or #369
Closed

Add Docker Support #367

magneticstain opened this issue Jan 15, 2024 · 3 comments · Fixed by #368 or #369
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@magneticstain
Copy link
Owner

Feature Summary
Add support for IP2CR as a docker image.

Motivations / Use Cases For Feature
A lot of users prefer running tools within a docker container. As such, we should add Docker image support for IP2CR.

Additional context
We should aim to host this on dockerhub/an alternate as well for ease-of-use.

@magneticstain magneticstain added the enhancement New feature or request label Jan 15, 2024
@magneticstain magneticstain self-assigned this Jan 15, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in IP-2-CloudResource Jan 15, 2024
@magneticstain magneticstain moved this from 📋 Backlog to 🏗 In progress in IP-2-CloudResource Jan 15, 2024
@magneticstain magneticstain added this to the v1.4.0 milestone Jan 15, 2024
@magneticstain magneticstain linked a pull request Jan 17, 2024 that will close this issue
@magneticstain
Copy link
Owner Author

magneticstain commented Jan 20, 2024

Docker support has been added.

Second part of this is:

@magneticstain
Copy link
Owner Author

e8e7e26

@magneticstain
Copy link
Owner Author

magneticstain commented Jan 20, 2024

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IP-2-CloudResource Jan 20, 2024
magneticstain added a commit that referenced this issue Jan 20, 2024
* Update version for new release

* Update app environment in rollbar config for new release

* Update changelog filters for goreleaser to make improve changelogs

* Minor: Add 2024 Roadmap to README

Also update changelog filter in goreleaser config to be more robust

* Minor: Add issue #367 to 2024 roadmap in README

* Add Initial Dockerfile (#368)

* Add initial Dockerfile

* Add docker info in install section of README

* Update Docker run command to remove after run

This should help prevent users accumulating unneeded IP2CR images after each run

* Check `Docker Support` Issue Off Roadmap in README

* Add Github Actions Workflow For Container Publish (#369)

* Add initial Dockerfile

* Add docker info in install section of README

* Update Docker run command to remove after run

This should help prevent users accumulating unneeded IP2CR images after each run

* Check `Docker Support` Issue Off Roadmap in README

* Add container publish Github Actions workflow

* Update GHCR password secret nemat

Docs note that using this format will allow GA to auto generate a token for pakcage publishing.

* Update README to include container registry install options

* Add Logo to README (#370)

- Other minor fixes in README

* Update code for release prep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
1 participant