Fix BasicAuth #94

config/config.exs

@@ -25,11 +25,6 @@ config :logger, :console,
 # The local timezone where the app is deployed.
 config :magpie, :timezone, "Europe/Berlin"
 
-# Define a default. Only override in production where the app is accessible by the others
-config :magpie,
-       :no_basic_auth,
-       true
-
 # Import environment specific config. This must remain at the bottom
 # of this file so it overrides the configuration defined above.
 import_config "#{Mix.env()}.exs"

config/dev.exs

@@ -46,10 +46,10 @@ config :magpie, Magpie.Repo,
   database: "magpie_dev",
   pool_size: 10
 
-# Used for basic_auth
-config :magpie, :authentication,
-  username: "default",
-  password: "password"
+# No real need for basic auth in dev
+config :magpie,
+       :no_basic_auth,
+       false
 
 config :magpie, :environment, :dev
 

config/prod.exs

@@ -4,3 +4,13 @@ config :logger,
   level: :info
 
 config :magpie, :environment, :prod
+
+# We don't have a basic auth on the demo app, so we need to allow for this flexibility
+# Deliberate compile-time variable
+config :magpie,
+       :no_basic_auth,
+       (if System.get_env("MAGPIE_NO_BASIC_AUTH") == "true" do
+          true
+        else
+          false
+        end)

config/releases.exs

@@ -46,15 +46,6 @@ config :magpie, :authentication,
   username: System.fetch_env!("AUTH_USERNAME"),
   password: System.fetch_env!("AUTH_PASSWORD")
 
-# We don't have a basic auth on the demo app
-config :magpie,
-       :no_basic_auth,
-       (if System.get_env("MAGPIE_NO_BASIC_AUTH") == "true" do
-          true
-        else
-          false
-        end)
-
 config :logger,
   backends:
     (if System.get_env("USE_TIMBER") == "true" do

config/test.exs

@@ -18,11 +18,6 @@ config :magpie, :sql_sandbox, true
 # Print only warnings and errors during test
 config :logger, level: :warn
 
-# Need to test it in the test environment.
-config :magpie,
-       :no_basic_auth,
-       false
-
 # Used for basic_auth
 config :magpie, :authentication,
   username: "default",