Set up continuous deployment of a production docker container #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah esbuild is a bundler written in Go that doesn't require Node.js to be installed. Probably the command in the Dockerfile to compile the assets will have to change though to use it. I'll take a look. |
x-ji
force-pushed
the
master
branch
2 times, most recently
from
e88585a
to
71a8e0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the backend continues to evolve, it would be cool to have a CD pipeline for the prod container that is used in the end-to-end tests.
This PR adds a GitHub Action that automatically builds and pushes the prod container whenever commits are pushed to master.
NB: I'm not sure the Dockerfile is correct as magpie-docker has been failing for a while with your newest changes (likely the esbuild change)
@x-ji Feel free to fix as you see fit