[Enh]: Mementos - Only Copy Checked Original #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were *always* copying field values when pulling so that the `original` could query whether the model had changed elsewhere. However, this created complication in other contexts (e.g. display of current data) where you want the real objects. So we simplify and only copy for the one use case where we currently need it (otherwise just use the real objects)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always copying field values when pulling so that the
originalcould query whether the model had changed elsewhere. However, this created complication in other contexts (e.g. display of current data) where you want the real objects. So we simplify and only copy for the one use case where we currently need it (otherwise just use the real objects)