Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate statement to tsx #47

Merged
merged 14 commits into from
Mar 13, 2023
Merged

chore: migrate statement to tsx #47

merged 14 commits into from
Mar 13, 2023

Conversation

aizad-deriv
Copy link
Collaborator

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@mahdiyeh-deriv mahdiyeh-deriv force-pushed the Improvement/72232/Reports_TS_migration branch from 6bd8359 to 2b9e1ea Compare March 2, 2023 11:17
mahdiyeh-deriv
mahdiyeh-deriv reviewed Mar 12, 2023
View reviewed changes
packages/reports/src/Constants/data-table-constants.tsx
payload={row_obj.contract_info}
should_show_multiplier={false}
/>
<MarketSymbolIconRow key={row_obj.id} payload={row_obj.contract_info} should_show_multiplier={false} />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the packages/reports/src/Components/market-symbol-icon-row.tsx path the show_description should be optional in the TMarketSymbolIconRow type

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the show_description?: boolean; in TMarketSymbolIconRow is already optional.

@mahdiyeh-deriv mahdiyeh-deriv merged commit 6a09c3d into mahdiyeh-deriv:Improvement/72232/Reports_TS_migration Mar 13, 2023
mahdiyeh-deriv added a commit that referenced this pull request Jun 23, 2023
@mahdiyeh-deriv @aizad-deriv
@akmal-deriv @likhith-deriv @sergei-deriv @kate-deriv @farzin-deriv @rostislav-deriv @thisyahlen-deriv @hirad-deriv
refactor: TS migration of Reports pakage (binary-com#7300)
8869ce1 
* refactor: initial commit

* revert: revert changes

* chore: ts-migration for positions-card.tsx (#5)

* chore: reports-table-row to tsx (#10)

* chore: migrating error-components to tsx (#8)

* chore: migrating error-components to tsx

* fix: added partial to type

* chore: migrate calendar-icon to tsx (#11)

* chore: migrate calendar-icon to tsx

* fix: updated extensions

* chore: migrate list-item to tsx (#12)

* chore: migrate currency-wrapper to ts (#17)

* chore: migrate empty-portfolio-message to ts (#18)

* chore: migrating reports meta to tsx (#23)

* chore: migrate amount-cell to ts (#16)

* chore: migrate amount-cell to ts

* fix: delete component because it is unused

* chore: migrating EmptyTradeHistoryMessage to tsx (#19)

* chore: migrating EmptyTradeHistoryMessage to tsx

* fix: remove extension

* fix: migrated sidelist to tsx (#13)

* fix: migrated sidelist to tsx

* fix: circle-ci error

* fix: sidelist types

* chore: migrate composite calendar mobile to typescript (#26)

* chore: migrate composite calendar mobile to typescript

* fix: remove component extension from the name

* refactor: ♻️ removed unused component (#30)

* chore: migrate index file to typescript (#27)

* refactor: ♻️ migrate component to tsx (#29)

* chore: two-month-picker to tsx with one calendar component (#15)

* chore: migrate account statistics to ts (#14)

* chore: migrate account statistics to ts

* fix: typo in comment

* Akmal / chore: migrate routes config to typescript (#31)

* chore: migrate routes config to typescript

* fix: change type for component

* Akmal / chore: migrate data-table-constants to typescript (#33)

* chore: migrate data-table-constants to typescript

* fix: refactor types

* chore: migrate loading component to typescript (#36)

* Aizad/73988/msir ts (#21)

* chore: migrate market-symbol-icon-row to ts

* fix: remove commented lines

* fix: remove classname from IconTradeTypes

* fix: removed action prop

* Sergei / chore: migrate open-positions to tsx (#40)

* chore: convert open-positions to tsx

* fix: add React.PropsWithChildren to tabs.tsx

* fix: change Tabs type

* fix: add/change some types and fix some undefined values

* refactor: use Return Early pattern for contract-card-sell component

* chore: delete commented lines

* chore: add moment as dev dependency

* chore: commit to check circleCI

* fix: change back tabs.tsx

* fix: change React.Fragment to null

* Akmal / chore: convert helpers to typescript (#28)

* chore: convert elpers to typescript

* fix: types

* chore: migrate placeholder to tsx (#42)

* chore: migate placeholder to tsx

* fix: destructure props and remove React.propswithchildre

* Sergei / 73980 / chore: ts migration of route-with-sub-routes (#45)

* chore: ts migration of route-with-sub-routes

* refactor: add common types to separate files

* fix: get back composite-calendar

* refactor: change path from absolute to relative for Types

* Sergei / 73979 / chore: ts migration of binary-routes (#46)

* chore: ts migration of binary-routes.jsx

* chore: add TPassthrough type and add key as index when route.path is undefined

* chore: add export for TBinaryRoutes type

* refactor: use types from common types

* Aizad/73977/binary link ts (#41)

* chore: migrate routes folder to tsx

* fix: change type for component

* fix: migrated test cases to tsx

* chore: migrate binary-links to tsx

* fix: change back function names

* fix: resolved conflict issues

* fix: testcases

* chore: migrated filter component and fix some issues with composite-c… (#20)

* chore: migrated filter component and fix some issues with composite-calendar

* fix: change export to CalendarIcon on index.js and added RootStore type to filter-components

* fix: change TRootStore to RootStore

* fix: replace RootStore to TRootStore

* fix: expand object for filtered_date_range

* Sergei / chore: ts migration of routes (#38)

* chore: ts migration of routes

* chore: change RootStore type

* Aizad/73994/pss ts (#48)

* chore: migrate progress-slider-stream to tsx

* fix: imported TContractInfo inside deriv/shared/

* Sergei / chore: migrate statements to tsx (#39)

* chore: ts migration of statements

* chore: change RootStore type

* chore: change local TRootStore with module property

* fix: return class RootStore to Stores/index.ts

* chore: change core_store type

* chore: migrated indicative cell to tsx (#44)

* chore: migrated indicative cell to tsx

* fix: added types to usestate

* fix: change type

* fix: change function type to boolean

* fix: imported TContractInfo from shared file into indicative-cell

* fix: test

* fix: mockstore

* fix: format-response.ts

* fix: mockstore

* Aizad/73978/routes ts (#50)

* Merge branch 'Improvement/72232/Reports_TS_migration' of github.com:mahdiyeh-deriv/deriv-app into ts-migration

* chore: finalising routes folder migration for Reports package 📦

* Akmal / chore: migrate app.jsx to typescript (#37)

* chore: migrate app.jsx to typescript

* chore: utilize TRootStore type

* chore: replace type

* Akmal / chore: migrate composite calendar to typescript (#25)

* chore: migrate composite calendar to typescript

* chore: refactor composite calendar and related components to properly use moment

* chore: move out index changes

* feat: resolve conflicts

* feat: add deriv stores package

* Kate/73995/TS migration of Reports (#51)

* refactor: migrate reports component into ts

* refactor: add useStore hook

* refactor: delete extra react fragment

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

---------

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

* redeploy: rerun tests

* refactor: remove named import from react

* chore: migrate statement to tsx (#47)

* chore: migrate statement to tsx

* fix: use Statement props from api-types than declaring it in ts file

* fix: imported TAccountStatistics inside statement

* fix: made changes based on comments

* fix: refactor based on suggestions

* fix: types in packages/shared/src/utils/shortcode/shortcode.ts

* fix: regex to prevent sonarcloud bug

* chore: change index.js to index.ts

* Rostislav / 73993 / Task - TS migration of ProfitTable (#34)

* refactor: init pr

* refactor: profit_loss_cell tsx'd

* refactor: profit_loss_cell import problem resolved

* refactor: profit_loss_cell import another problem fix

* refactor: the migration is more or less finished

* refactor: a few extra changes

* refactor: prev commit accidental changes removed

* refactor: TProfitTable type changed a bit

* refactor: moved types to common-prop.type.ts

* refactor: getSupportedContracts and getUnsupportedContracts moved to shared

* refactor: contract.tsx completely replaced by imports from @deriv/shared

* refactor: added alias for Types

* refactor: applied suggested changes

* fix: regex for sonarcloud

* fix: remove props from the name of type declaration

* fix: resolve comments

* fix: fix comments v2

* fix: remove usestate

* fix: date-time test

* fix: comments v3

* thisyahlen/fix: trade table for mobile (#52)

* fix: trade table for mobile

* fix: trade table error

* fix: statement input validation error on date_from

* fix: setdate unix

* fix: responsive input validation error

* fix: remove unix from store

---------

Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com>
Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com>
Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com>
Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com>
Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com>
Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>
Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com>
Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com>
Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com>
Co-authored-by: hirad-deriv <hirad@re-work.dev>
mahdiyeh-deriv pushed a commit that referenced this pull request Sep 29, 2023
@likhith-deriv
accounts/refactor: ♻️ container section in accounts package (binary-c…
c39e179 
…om#9832)

* refactor: ♻️ initial commit

* refactor: 🎨 fixed import file paths

* fix: 🧑‍💻 incorporate sonarcloud review

* refactor: ♻️ migrated reset-trading-password component to TSX

* refactor: 🎨 resolved build failure

* fix: ♻️ incorporated lint errors

* fix: 🎨 incorporated review comments

* fix: 🐛 resize issue

* refactor: 🎨 migrated account component to TSX (#47)

* refactor: 🎨 migrated account component to TSX

* fix: 🎨 refactored code

* refactor: 🎨 migrated account to tsx

* fix: 🎨 incorporated review comments

* chore: 💚 trigger empty commit

* fix: 🧪 failing testcase

* fix: 🐛 resolve password modal API failure

* fix: 🐛 bug regd disabled Financial Assessment

* fix: 🚚 updated paths

* Merge branch 'master' into sprint-9/account-package-refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suisin-deriv suisin-deriv suisin-deriv left review comments

@akmal-deriv akmal-deriv akmal-deriv approved these changes

@mahdiyeh-deriv mahdiyeh-deriv mahdiyeh-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aizad-deriv @akmal-deriv @mahdiyeh-deriv @suisin-deriv